Skip to content

Refactored icon usage to use new shortcode #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 15, 2025
Merged

Refactored icon usage to use new shortcode #801

merged 7 commits into from
Jul 15, 2025
+130 −130

Conversation

lamATnginx
Copy link
Contributor

@lamATnginx lamATnginx commented Jul 9, 2025 •
edited
Loading

Proposed changes

Closes https://github.com/nginxinc/docs-platform/issues/546

Must wait until nginxinc/nginx-hugo-theme#309 is merged completely into main.

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@lamATnginx lamATnginx self-assigned this Jul 9, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim NGINX Instance Manager product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) product/nginx-one NGINX One Console product/nginxaas NGINX as a Service for Azure product/agent NGINX Agent product/controller NGINX Controller (EOS product) product/mesh NGINX Service Mesh (EOS product) product/nms NGINX Management Suite (EOS product) labels Jul 9, 2025
@lamATnginx
Copy link
Contributor Author

Do NOT merge or review until mainframe is merged

@lamATnginx lamATnginx force-pushed the update-icon-usage branch from 20e8299 to a31b2eb Compare July 9, 2025 20:55
@github-actions github-actions bot added tooling Back end, repository, Hugo, and all things not related to content product/nic NGINX Ingress Controller related issues labels Jul 9, 2025
@lamATnginx lamATnginx force-pushed the update-icon-usage branch from a31b2eb to b20d91c Compare July 9, 2025 20:56
@lamATnginx lamATnginx changed the base branch from main to mainframe-mod-ref-testing July 15, 2025 17:25
@lamATnginx lamATnginx changed the base branch from mainframe-mod-ref-testing to mainframe July 15, 2025 17:25
@lamATnginx lamATnginx marked this pull request as ready for review July 15, 2025 17:37
@lamATnginx lamATnginx requested a review from a team as a code owner July 15, 2025 17:37
@lamATnginx
Copy link
Contributor Author

Merging into mainframe despite build failure.

@lamATnginx lamATnginx merged commit 6a8a927 into mainframe Jul 15, 2025
6 of 7 checks passed
@lamATnginx lamATnginx deleted the update-icon-usage branch July 15, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lamATnginx lamATnginx

Labels
documentation Improvements or additions to documentation product/agent NGINX Agent product/controller NGINX Controller (EOS product) product/mesh NGINX Service Mesh (EOS product) product/nginx-one NGINX One Console product/nginx-plus NGINX Plus (and NGINX Open Source in docs.ngninx.com) product/nginxaas NGINX as a Service for Azure product/nic NGINX Ingress Controller related issues product/nim NGINX Instance Manager product/nms NGINX Management Suite (EOS product) tooling Back end, repository, Hugo, and all things not related to content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lamATnginx